New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set urgency on linux notifications #20152
Conversation
5a4f279
to
7c8868a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make this cross-platform as far as windows --> https://docs.microsoft.com/en-us/uwp/api/windows.ui.notifications.toastnotification.priority
macOS does not support changing the notificaiton priority at runtime.
82aa2b9
to
caed6a7
Compare
a9db090
to
0a40a19
Compare
0a40a19
to
2a3e4d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarshallOfSound is right about making this x-platform, but it doesn't all need to happen in one PR. This PR LGTM for Linux.
Co-Authored-By: Charles Kerr <ckerr@github.com>
54e62fa
to
655eaf1
Compare
Release Notes Persisted
|
Description of Change
Enable users to customize the
urgency
levels of Linux notifications.Checklist
npm test
passesRelease Notes
Notes: Added an
urgency
property to allow customization of Linux-based notifications.